[Dashboard] Replace Discord icon #4816

kien-ngo · 2024-09-26T16:36:21Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on replacing the usage of the SiDiscord icon from @react-icons with a custom DiscordIcon component across several files in the dashboard application.

Detailed summary

Replaced SiDiscord icon with DiscordIcon in edit-profile.tsx.
Updated SOCIALS array in socialLinks.tsx to use DiscordIcon.
Changed PublisherSocials component to use DiscordIcon.
Added DiscordIcon component in DiscordIcon.tsx with SVG implementation.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-09-26T16:36:24Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 27, 2024 1:59am

3 Skipped Deployments

Name	Status	Updated (UTC)
docs-v2	⬜️ Skipped (Inspect)	Sep 27, 2024 1:59am
thirdweb_playground	⬜️ Skipped (Inspect)	Sep 27, 2024 1:59am
wallet-ui	⬜️ Skipped (Inspect)	Sep 27, 2024 1:59am

changeset-bot · 2024-09-26T16:36:25Z

⚠️ No Changeset found

Latest commit: b1d78b1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-09-26T16:36:27Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

kien-ngo · 2024-09-26T16:36:41Z

[Dashboard] Remove @react-icons/all-files #4819
[Dashboard] Replace Linkedin icon #4818
[Dashboard] Replace twitter icon #4817
[Dashboard] Replace Discord icon #4816 👈
[Dashboard] Replace Unity icon #4814
[Dashboard] Replace React icon #4813
[Dashboard] Replace JS and TS icons #4812
[Dashboard] Replace SiGithub #4811
[Dashboard] Remove non-branding icons #4810
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite

github-actions · 2024-09-26T16:39:48Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	41.93 KB (0%)	839 ms (0%)	3.2 s (+57.29% 🔺)	4 s
thirdweb (cjs)	101.55 KB (0%)	2.1 s (0%)	5.1 s (-3.99% 🔽)	7.1 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	449 ms (+147.33% 🔺)	545 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	96 ms (-1.76% 🔽)	106 ms
thirdweb/react (minimal + tree-shaking)	16.78 KB (0%)	336 ms (0%)	589 ms (-42.36% 🔽)	925 ms

apps/dashboard/src/components/footer/socialLinks.tsx

codecov · 2024-09-27T01:33:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.67%. Comparing base (bc348ea) to head (b1d78b1).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4816   +/-   ##
=======================================
  Coverage   47.67%   47.67%           
=======================================
  Files        1051     1051           
  Lines       56715    56715           
  Branches     3894     3894           
=======================================
  Hits        27040    27040           
  Misses      28988    28988           
  Partials      687      687

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from bc348ea
packages	`43.40% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

graphite-app · 2024-09-27T01:51:44Z

Merge activity

Sep 26, 9:51 PM EDT: jnsdls added this pull request to the Graphite merge queue.
Sep 26, 10:00 PM EDT: jnsdls merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on replacing the usage of the `SiDiscord` icon from `@react-icons/all-files` with a custom `DiscordIcon` component in multiple files, enhancing the icon's integration and potentially improving styling consistency. ### Detailed summary - Replaced `SiDiscord` icon with `DiscordIcon` in: - `edit-profile.tsx` - `socialLinks.tsx` - `PublisherSocials.tsx` - Introduced `DiscordIcon` component in `DiscordIcon.tsx` with an SVG representation. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

vercel bot temporarily deployed to Preview – thirdweb_playground September 26, 2024 16:36 Inactive

vercel bot temporarily deployed to Preview – wallet-ui September 26, 2024 16:36 Inactive

vercel bot temporarily deployed to Preview – docs-v2 September 26, 2024 16:36 Inactive

github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 26, 2024

kien-ngo changed the title ~~:replace discord icon~~ [Dashboard] Replace Discord icon Sep 26, 2024

This was referenced Sep 26, 2024

[Dashboard] Remove non-branding icons #4810

Merged

[Dashboard] Replace SiGithub #4811

Merged

[Dashboard] Replace JS and TS icons #4812

Merged

[Dashboard] Replace React icon #4813

Merged

kien-ngo mentioned this pull request Sep 26, 2024

[Dashboard] Replace Unity icon #4814

Merged

kien-ngo marked this pull request as ready for review September 26, 2024 16:36

kien-ngo requested review from MananTank, jnsdls and joaquim-verges as code owners September 26, 2024 16:36

vercel bot deployed to Preview – thirdweb-www September 26, 2024 16:45 View deployment

This was referenced Sep 26, 2024

[Dashboard] Replace twitter icon #4817

Merged

[Dashboard] Replace Linkedin icon #4818

Merged

[Dashboard] Remove @react-icons/all-files #4819

Merged

MananTank reviewed Sep 27, 2024

View reviewed changes

apps/dashboard/src/components/footer/socialLinks.tsx Outdated Show resolved Hide resolved

MananTank changed the base branch from kien/replace-unity-icon to graphite-base/4816 September 27, 2024 01:26

kien-ngo force-pushed the graphite-base/4816 branch from 3c4405d to bc348ea Compare September 27, 2024 01:32

kien-ngo force-pushed the kien/replace-discord-icon branch from 37a2793 to 30a9e87 Compare September 27, 2024 01:32

vercel bot temporarily deployed to Preview – docs-v2 September 27, 2024 01:32 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground September 27, 2024 01:32 Inactive

vercel bot temporarily deployed to Preview – wallet-ui September 27, 2024 01:32 Inactive

kien-ngo requested a review from MananTank September 27, 2024 01:34

jnsdls approved these changes Sep 27, 2024

View reviewed changes

MananTank changed the base branch from graphite-base/4816 to main September 27, 2024 01:41

MananTank force-pushed the kien/replace-discord-icon branch from 30a9e87 to 246439f Compare September 27, 2024 01:41

vercel bot temporarily deployed to Preview – docs-v2 September 27, 2024 01:41 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground September 27, 2024 01:41 Inactive

vercel bot temporarily deployed to Preview – wallet-ui September 27, 2024 01:41 Inactive

vercel bot deployed to Preview – thirdweb-www September 27, 2024 01:51 View deployment

jnsdls force-pushed the kien/replace-discord-icon branch from 246439f to b1d78b1 Compare September 27, 2024 01:52

vercel bot temporarily deployed to Preview – docs-v2 September 27, 2024 01:52 Inactive

vercel bot temporarily deployed to Preview – wallet-ui September 27, 2024 01:52 Inactive

vercel bot temporarily deployed to Preview – thirdweb_playground September 27, 2024 01:52 Inactive

vercel bot deployed to Preview – thirdweb-www September 27, 2024 01:59 View deployment

graphite-app bot merged commit b1d78b1 into main Sep 27, 2024

graphite-app bot deleted the kien/replace-discord-icon branch September 27, 2024 02:00

vercel bot temporarily deployed to Production – wallet-ui September 27, 2024 02:00 Inactive

vercel bot temporarily deployed to Production – thirdweb_playground September 27, 2024 02:00 Inactive

vercel bot temporarily deployed to Production – docs-v2 September 27, 2024 02:00 Inactive

vercel bot deployed to Production – thirdweb-www September 27, 2024 02:10 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Dashboard] Replace Discord icon #4816

[Dashboard] Replace Discord icon #4816

Uh oh!

kien-ngo commented Sep 26, 2024 •

edited by pr-codex bot

Loading

Uh oh!

vercel bot commented Sep 26, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Sep 26, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 26, 2024

Uh oh!

kien-ngo commented Sep 26, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Sep 26, 2024 •

edited

Loading

Uh oh!

Uh oh!

codecov bot commented Sep 27, 2024 •

edited

Loading

Uh oh!

graphite-app bot commented Sep 27, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Dashboard] Replace Discord icon #4816

[Dashboard] Replace Discord icon #4816

Uh oh!

Conversation

kien-ngo commented Sep 26, 2024 • edited by pr-codex bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem solved

PR-Codex overview

Detailed summary

Uh oh!

vercel bot commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

graphite-app bot commented Sep 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Uh oh!

kien-ngo commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Sep 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

Uh oh!

codecov bot commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

graphite-app bot commented Sep 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kien-ngo commented Sep 26, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Sep 26, 2024 •

edited

Loading

changeset-bot bot commented Sep 26, 2024 •

edited

Loading

kien-ngo commented Sep 26, 2024 •

edited

Loading

github-actions bot commented Sep 26, 2024 •

edited

Loading

codecov bot commented Sep 27, 2024 •

edited

Loading

graphite-app bot commented Sep 27, 2024 •

edited

Loading